lytedev/nix
Watch
1
0
Fork
You've already forked nix
 2
Code Pull requests 59 Activity Actions

feat(assistant): support source-bound private continuation protocol #1634

Open
lytedev wants to merge 2 commits from propose/private-query-client-protocol into propose/private-query-notice-tickets
pull from: propose/private-query-client-protocol
merge into: lytedev:propose/private-query-notice-tickets
Conversation 0 Commits 2 Files changed 3 +66 -4
lytedev commented 2026-11-01 01:27:02 -06:00
Owner
Copy link

See the commits.

See the commits.
feat(assistant): decode source-bound private continuation actions
Some checks failed
/ check-format (push) Has been cancelled
Details
/ build (push) Has been cancelled
Details
68ab223d0b 
Keep continuation references in the canonical authenticated create
request with deterministic identifiers. Decode the same closed public
action on notice reads and streams without accepting command approvals
or private destinations as extra fields.

This is protocol support only, not automatic switching or Local query
execution. Focused UI and strict checks are pending on bigtower.
fix(assistant): distinguish continuation from command approval
Some checks failed
/ check-format (push) Successful in 17s
Details
/ build (push) Failing after 13m40s
Details
bb55585ca2 
The first protocol run passed all 36 selected client tests but its full
UI strict check correctly rejected command-only field accesses on the
new action union. Narrow command handling and rendering by kind rather
than hiding the distinction with a cast.

Full UI revalidation is pending; the initial run is not green.
Some checks failed
/ check-format (push) Successful in 17s
Details
/ build (push) Failing after 13m40s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin propose/private-query-client-protocol:propose/private-query-client-protocol
git switch propose/private-query-client-protocol

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch propose/private-query-notice-tickets
git merge --no-ff propose/private-query-client-protocol
git switch propose/private-query-client-protocol
git rebase propose/private-query-notice-tickets
git switch propose/private-query-notice-tickets
git merge --ff-only propose/private-query-client-protocol
git switch propose/private-query-client-protocol
git rebase propose/private-query-notice-tickets
git switch propose/private-query-notice-tickets
git merge --no-ff propose/private-query-client-protocol
git switch propose/private-query-notice-tickets
git merge --squash propose/private-query-client-protocol
git switch propose/private-query-notice-tickets
git merge --ff-only propose/private-query-client-protocol
git switch propose/private-query-notice-tickets
git merge propose/private-query-client-protocol
git push origin propose/private-query-notice-tickets
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something is wrong

  
enhancement
New feature

  
question
Awaiting information

  
scary
Potentially problematic change

  
upstream
Awaiting upstream changes

No labels
bug
enhancement
question
scary
upstream
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
lytedev/nix!1634
No description provided.