lytedev/nix
Watch
1
0
Fork
You've already forked nix
 2
Code Pull requests 59 Activity Actions

feat(assistant): advisory private query notice tickets #1631

Open
lytedev wants to merge 6 commits from propose/private-query-notice-tickets into main
pull from: propose/private-query-notice-tickets
merge into: lytedev:main
Conversation 0 Commits 6 Files changed 18 +2114 -345
lytedev commented 2026-11-01 01:10:14 -06:00
Owner
Copy link

See the commits.

See the commits.
fix(assistant): bind command approval to operator session
Some checks failed
/ check-format (push) Has been cancelled
Details
/ build (push) Has been cancelled
Details
32a2c2c018 
Validation uses faux providers, synthetic credentials, temporary SQLite
stores and mocked executor effects; no production model or audio calls.
The regression probe against e9b69183 confirmed that an ambient service
"yes" could create a spendable grant before this change.

Passed 204 offline tests across command approvals/tools, notice projection,
registered core ingress, signed backend/SSE, browser gateway, composition,
authenticated authority and voice transport. Syntax checks and nix fmt
pass. Strict TypeScript passes for command approvals, host notices and
approved commands, including their unit tests.

The full integration closure remains blocked by seven diagnostics already
present in fetched main e9b69183: agent management JSON typing, recursive
agent extension inference (two), missing readFileSync, missing
AssistantSession, the direct backend handle's dispatch arity, and private
continuity typing. A baseline source archive reports nine diagnostics;
the two old command-approval casts disappear with the v2 implementation.
Do not fold unrelated proposal fixes into this security change.
fix(assistant): integrate current authority and approval composition
Some checks failed
/ check-format (push) Has been cancelled
Details
/ build (push) Has been cancelled
Details
e132331995 
Merge main 64cb8e337f into the pushed approval proposal without rewriting
32a2c2c0. Retain both adjacent test declarations from the single conflict.

Passed 265 offline tests across registered core/operator approval,
voice receiver/session/CLI isolation, notices, SSE revocation, browser
gateway, composition and canonical authority. The final runtime suite
also passes all six tests, including startup with an additional receiver.
Syntax checks, active LSP checks on the three changed files and nix fmt
pass. Approval state, notice projection, the write-ahead outcome barrier
and identity/run bindings are unchanged from 32a2c2c0.

The full strict TypeScript closure, including composition and all selected
test suites, now has one outside-scope diagnostic:
agent_management_host.ts:219:84 assigns PiQuestionEndpoint to JsonValue;
PiQuestionEndpoint lacks the required string index signature. Leave this
visible for the owning worker rather than weakening or casting the type.

No deployment, production inference or audio calls were performed.
feat(assistant): constrain private handoffs to host-pinned household queries
Some checks failed
/ check-format (push) Has been cancelled
Details
/ build (push) Has been cancelled
Details
04580f775b
fix(assistant): keep query handoffs free of capability grants
All checks were successful
/ check-format (push) Successful in 17s
Details
/ build (push) Successful in 21m45s
Details
90695edea7
feat(assistant): add advisory private query notice tickets
Some checks failed
/ check-format (push) Has been cancelled
Details
/ build (push) Has been cancelled
Details
f474a67aa6
test(assistant): cover private query ticket isolation and tampering
All checks were successful
/ check-format (push) Successful in 22s
Details
/ build (push) Successful in 32m7s
Details
0799c342db
All checks were successful
/ check-format (push) Successful in 22s
Required
Details
/ build (push) Successful in 32m7s
Required
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin propose/private-query-notice-tickets:propose/private-query-notice-tickets
git switch propose/private-query-notice-tickets
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something is wrong

  
enhancement
New feature

  
question
Awaiting information

  
scary
Potentially problematic change

  
upstream
Awaiting upstream changes

No labels
bug
enhancement
question
scary
upstream
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
lytedev/nix!1631
No description provided.