feat(deck-pose,deck-slice): draw the camera feed as the game background #913
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "deck-video"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Daniel's request: "I think we should draw the actual camera feed as the background so users can feel how the tracking relates to their bodies."
Stacked on #911.
Your design — agreed, with one rejection
I agree with almost all of it and implemented it as specified: forward the original bytes, separate socket, opt-in and off by default, rate-limited independently, drop-never-queue, drawn in the play rect mirrored and dimmed.
I did not implement daemon-side downscale, because it contradicts "do not re-encode". Any change to the pixels — including making them smaller — means decode, scale and JPEG encode on the latency-critical path, to produce a worse image than the one already in hand. There is no cheap downscale of a JPEG.
Resolution is instead chosen where it is free: at the camera, via the existing
--width/--height, which shrinks the capture, the forward and the consumer's decode all at once.--video-fps(default 30) caps the rate as you asked. If you still want a daemon-side resize I will add it, but it should be a knowing trade of daemon latency for consumer convenience, not a default.Measured, as requested
Daemon cost, isolated on dragon (720p MJPEG, video capped at 30fps):
--publish-video, no consumerThe pose path is unaffected: with the game attached and decoding, the daemon holds 60.1 fps, P95 15.4 ms end-to-end, unchanged from baseline and far inside the 80 ms budget.
GDScript decode cost: 4-7 ms per 720p frame, the dominant cost of the whole feature, and it lands on the game rather than the input path. The game held 120 fps throughout.
One honest caution. Those are desktop numbers. In one earlier run under heavy contention I saw daemon inference stretch to 24-29 ms with the game decoding concurrently — not reproducible in the controlled runs, but a handheld doing inference and a game and a 30fps JPEG decode on four cores is a different proposition.
--video-fpsand a smaller capture are the levers, which is precisely why both are configurable.Does it subsume the vignette?
Partly, and I changed it accordingly rather than stacking redundant cues. With the feed up the image itself shows where the camera can see, so the explicit border drops to a hairline. The vignette stays only to darken what the camera cannot see, which is still doing real work. Without video, both revert to their previous strength.
Implementation notes
DPV1, length, width, height) then the JPEG. Length-prefixed because JPEG has no line structure; self-describing so a consumer reconnecting mid-stream can tell it is synchronised rather than guessing, and reconnect rather than scan if not.ImageTextureis reused rather than recreated per frame; allocating a GPU texture 30 times a second would have made this look expensive when the decode is the real cost.Checks
nix buildgreen for both packages. 50 daemon tests pass, including: header integrity and byte-for-byte payload equality, non-MJPEG formats skipped rather than converted, the rate limit holding against a burst, nothing sent with no consumer, and 500 frames offered at a consumer that never reads without blocking. Module evaluates with video on and emits the right config.Untested
Superseded by #915, which consolidates the whole markerless-pose-input program into a single WIP branch against
main. Every commit from this PR is preserved there — nothing was squashed, so the root-cause writeups in the commit messages are intact. Closing here; review happens on #915.Pull request closed